Add support for integer number to varchar coercer in unpartitioned table #22246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yiqun Zhang <[email protected]>
Praveen2112
requested review from
ssheikin,
guiyanakuang,
raunaqmorarka,
ebyhr,
krvikash,
findinpath,
vlad-lyutenko and
marcinsbd
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcTypeTranslator.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcTypeTranslator.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcTypeTranslator.java
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/int_to_varchar_coercer_un_partitioned_tables
branch
from
d427803 to
3981886
Compare
|
Thanks a lot for the review @raunaqmorarka . I have attempted to implement the same for parquet also - Not sure if it is the correct direction or usage of proper APIs. |
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetTypeTranslator.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetTypeTranslator.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetTypeTranslator.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/parquet/ParquetPageSourceFactory.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OrcTypeTranslator.java
Show resolved
Hide resolved
Co-authored-by: Yiqun Zhang <[email protected]>
Praveen2112
force-pushed
the
praveen/int_to_varchar_coercer_un_partitioned_tables
branch
from
3981886 to
d9fcb46
Compare
Praveen2112
force-pushed
the
praveen/int_to_varchar_coercer_un_partitioned_tables
branch
from
d9fcb46 to
0beee5e
Compare
raunaqmorarka
approved these changes
Jun 4, 2024
krvikash
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Integer number to varchar coercion is currently supported for partitioned tables and we are extending the same for un-partitioned tables as well.
Overrides #18295.
Part of #19643
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: