Add support for stats on timestamp type in Delta Lake #22159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
May 27, 2024
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Show resolved
Hide resolved
findepi
reviewed
May 27, 2024
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Show resolved
Hide resolved
ebyhr
commented
May 29, 2024
...-delta-lake/src/main/java/io/trino/plugin/deltalake/transactionlog/TransactionLogParser.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-stats
branch
3 times, most recently
from
91d5e77 to
65e1c3a
Compare
|
@findepi Addressed comments. |
findepi
reviewed
Jun 7, 2024
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/trino/plugin/deltalake/transactionlog/DeltaLakeParquetStatisticsUtils.java
Outdated
Show resolved
Hide resolved
| long epochSeconds = floorDiv(epochMicros, MICROSECONDS_PER_SECOND); | ||
| int nanoAdjustment = floorMod(epochMicros, MICROSECONDS_PER_SECOND) * NANOSECONDS_PER_MICROSECOND; | ||
| Instant ts = Instant.ofEpochSecond(epochSeconds, nanoAdjustment); | ||
| Instant truncatedToMillis = ts.truncatedTo(MILLIS); |
There was a problem hiding this comment.
- add a check that
typehas precision at least millis. - add a comment why truncating to millis even for timestamp micros
- however, it wouldn't be hard to pick the truncation unit based on timestamp precision, so maybe let's do that instead of the comment
There was a problem hiding this comment.
Are you suggesting a conversion from TimestampType.TIMESTAMP_MILLIS to ChronoUnit.MILLIS? Can you share the code snippet?
There was a problem hiding this comment.
Let me add a code comment instead. I didn't come up with a simple code for such a conversion.
...lake/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/CheckpointWriter.java
Outdated
Show resolved
Hide resolved
...lake/src/main/java/io/trino/plugin/deltalake/transactionlog/checkpoint/CheckpointWriter.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example of stats generated by Spark:
2020-08-26T01:02:03.1232024-05-29T15:08:00.991Z2020-08-26T01:02:03.123987with INT64Both int96 and int64 are allowed in parquet files: https://github.com/delta-io/delta/blob/master/PROTOCOL.md#delta-data-type-to-parquet-type-mappings
Fixes #21878
Release notes
(x) Release notes are required, with the following suggested text: