Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend automatic type coercion support in Delta table creation to char #22049

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

SemionPar
Copy link
Contributor

Description

  • extend automatic type coercion support in Iceberg table creation to char type
  • generify existing test names

Additional context and related issues

#21515

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@ebyhr
Copy link
Member

ebyhr commented May 21, 2024

Could you confirm CI failure?

Error:    TestDeltaLakeAlluxioCacheMinioAndHmsConnectorSmokeTest>BaseDeltaLakeConnectorSmokeTest.testCharTypeIsNotSupported:298->AbstractTestQueryFramework.assertQueryFails:445 Expected query to fail: CREATE TABLE test_char_type_not_supported1l1p3azzoy (a int, b CHAR(5)) WITH (location = 's3://test-delta-lake-integration-smoke-test-tfbohsp0r0/test_char_type_not_supported1l1p3azzoy') [QueryId: 20240521_075142_00955_h3d6i]
Error:    TestDeltaLakeMinioAndHmsConnectorSmokeTest>BaseDeltaLakeConnectorSmokeTest.testCharTypeIsNotSupported:298->AbstractTestQueryFramework.assertQueryFails:445 Expected query to fail: CREATE TABLE test_char_type_not_supportedb45k3qefnm (a int, b CHAR(5)) WITH (location = 's3://test-delta-lake-integration-smoke-test-qzd44p5sxb/test_char_type_not_supportedb45k3qefnm') [QueryId: 20240521_075202_01004_wdpaa]

@findinpath findinpath requested a review from pajaks May 21, 2024 21:05
@SemionPar SemionPar force-pushed the semionpar/char-in-delta-ctas branch 2 times, most recently from ae3b041 to 8431b2f Compare May 31, 2024 14:21
@SemionPar
Copy link
Contributor Author

Removed the failing test as it is now supported.

@ebyhr
Copy link
Member

ebyhr commented Jun 3, 2024

/test-with-secrets sha=8431b2f26da2dffb351d1fc730151bc2135a58cd

Copy link

github-actions bot commented Jun 3, 2024

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/9344906683

Similar to trinodb#21515, extend type coercion support to char type.
@SemionPar SemionPar force-pushed the semionpar/char-in-delta-ctas branch from 8431b2f to 8d782f1 Compare June 4, 2024 15:51
@ebyhr ebyhr merged commit 6a0e30f into trinodb:master Jun 5, 2024
25 checks passed
@github-actions github-actions bot added this to the 450 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector
Development

Successfully merging this pull request may close these issues.

3 participants