Use idiom query runner setup to close on failure #21584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move query runner setup to createQueryRunner in Iceberg MV tests.
findepi
added
test
no-release-notes
github-actions
bot
added
delta-lake
losipiuk
approved these changes
Apr 17, 2024
The method was skipping all the state configured in the builder, so it was just a hack. Replace with proper setup for custom connector properties.
Replace dedicated configuration setters (some unused) with connector configuration properties (as typically done in other query builders).
Typically query runner implementations provide builder as part of the main query runner class. Adjust `TpchQueryRunner` to follow the suite, moving `TpchQueryRunnerBuilder` to be an inner class.
Additional setup functionality is provided generically by DistributedQueryRunner and happened before subclass's build, which often installs a catalog, copies data. This was a non-intuitive control flow. Move the additional setup invocation after the query runner is built by moving the subclass's build logic from build override to a new configure method.
|
replaced with a PR that will run with secrets #21588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.