Clean up Snowflake type mapping code #21405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-with-secrets sha=98fe1e1753ab733347114007af44dd971cd0966f |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8562287121 |
ebyhr
approved these changes
Apr 10, 2024
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-snowflake/src/main/java/io/trino/plugin/snowflake/SnowflakeClient.java
Outdated
Show resolved
Hide resolved
|
Please rebase on master to resolve conflicts. |
|
@ebyhr Thanks for the review. Just addressed the comments. Added as a separate commit so please help squash them when merging. |
|
/test-with-secrets sha=105a60a2b50baa7dab33873d684f39d2eda53cee |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8654894697 |
1. Replace maps with switch/case statements to avoid repetitive building of the maps. 2. Re-order types so that the order is consistent with other connectors. 3. Inlining/renaming some methods for better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splitting #21012 into incremental ones. This is the first part of it.
Description:
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: