Fix dictionary handling in AggregationMaskCompiler #21363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test to avoid future regressions? |
losipiuk
reviewed
Apr 2, 2024
| Variable position = scope.declareVariable("position", body, constantInt(0)); | ||
| BytecodeExpression isPositionSelected = testMaskBlock(maskValueBlock, maskBlockMayHaveNull, position); | ||
| Variable maskValueBlockPosition = scope.declareVariable("maskValueBlockPosition", body, constantInt(0)); | ||
| BytecodeExpression isMaskPositionSelected = testMaskBlock(maskValueBlock, maskBlockMayHaveNull, maskValueBlockPosition); |
there are repro steps in #21272 (comment). |
|
@findepi test cases are not part of this change |
Reproducing this requires a specific organization of blocks and dictionaries, so using a query to do this is pretty brittle. To really test this the aggregation mask must be driven manally with the correct combination of blocks. I might be able to look at adding a test like that today, but it will likely be tomorrow or Friday. |
martint
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generated AggregationMask was not properly handling dictionary encoded mask blocks.
Fixes #21272
Release notes
(x) Release notes are required, with the following suggested text: