Fix potentially incorrect table read version for writes on Delta Lake #21330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
force-pushed
the
findinpath/delta-fix-concurrency-issue
branch
from
42f46bb to
9b75b58
Compare
|
/test-with-secrets sha=9b75b58eb3ff26c91f98196be90aece77c33c617 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/8506204061 |
ebyhr
reviewed
Apr 1, 2024
...lta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeLocalConcurrentWritesTest.java
Show resolved
Hide resolved
...lta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeLocalConcurrentWritesTest.java
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-fix-concurrency-issue
branch
from
9b75b58 to
14cfb6d
Compare
|
@ebyhr pls trigger a new build with secrets |
|
/test-with-secrets sha=14cfb6df6e2e1d2ce7f3655ed30db7fe801c391c |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8518514728 |
|
From the build https://github.com/trinodb/trino/actions/runs/8518514728/job/23330834685 , I see that the delta-lake cloud-tests finished successfully. |
findepi
reviewed
Apr 2, 2024
| table.getMetadataEntry(), | ||
| table.getProtocolEntry(), | ||
| inputColumns, | ||
| getMandatoryCurrentVersion(fileSystem, tableLocation, table.getReadVersion()), |
findepi
approved these changes
Apr 2, 2024
...lta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeLocalConcurrentWritesTest.java
Show resolved
Hide resolved
In the context of concurrent operations, it may potentially happen that between the time when the version of table has been initially read for scanning and the time when the planning of the write operation begins that a new version of the table is current. Nevertheless, use in performing the write operations the version of the table initially read as reference for beginning the operation to ensure the consistency of the operation. This strategy helps in unintentionally skipping the processing of transaction log information corresponding to other concurrent operations.
Without the fix in the previous commit, in the concurrency tests for the non-blind INSERT operations it happened sometime that the source table handles processed in `finishInsert` operation were wrongly skipped because they were considered time travel references of the target table which led to the situation in which the INSERT operation was inaccurately considered blind.
findinpath
force-pushed
the
findinpath/delta-fix-concurrency-issue
branch
from
14cfb6d to
1941f3f
Compare
findinpath
changed the title
3 tasks
ebyhr
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the context of concurrent operations, it may potentially happen that between the time when the version of table has been initially read for scanning and the time when the planning of the write operation begins that a new version of the table is current. Nevertheless, use in performing the write operations the version of the table initially read as reference for beginning the operation to ensure the consistency of the operation.
This strategy helps in unintentionally skipping the processing of transaction log information corresponding to other concurrent operations.
Additional context and related issues
Fixes #21324
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: