Simplify derived effective predicate #21327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
ir-pp-tmp
branch
2 times, most recently
from
732b989 to
07290c7
Compare
dain
approved these changes
Mar 30, 2024
| case LESS_THAN_OR_EQUAL -> "$lte"; | ||
| case GREATER_THAN -> "$gt"; | ||
| case GREATER_THAN_OR_EQUAL -> "$gte"; | ||
| case IS_DISTINCT_FROM -> "$distinct"; |
There was a problem hiding this comment.
we should think about adding this to the enum
| @@ -2208,7 +2208,7 @@ public void testProjectionPushdownNonPrimitiveTypeExplain() | |||
| assertExplain( | |||
| "EXPLAIN SELECT id, _row.child, _array[1].child, _map[1] FROM " + tableName, | |||
| "ScanProject\\[table = (.*)]", | |||
| "expr(.*) := system\\.builtin\\.\\$operator\\$subscript\\(.*, bigint '1'\\).0", | |||
| "expr(.*) := .*\\$subscript\\(.*, bigint '1'\\).0", | |||
There was a problem hiding this comment.
Do we really want tests like this?
There was a problem hiding this comment.
No, I'm thinking about removing it. It's super brittle -- it breaks on every other PR that touches the IR.
Sort terms by symbol name and place null checks at the front.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.