Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JsonProperty annotation in Iceberg #21321

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Fix JsonProperty annotation in Iceberg #21321

merged 1 commit into from
Mar 29, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 29, 2024

Fixes #21319

@cla-bot cla-bot bot added the cla-signed label Mar 29, 2024
@ebyhr ebyhr added no-release-notes This pull request does not require release notes entry and removed cla-signed labels Mar 29, 2024
@github-actions github-actions bot added the iceberg Iceberg connector label Mar 29, 2024
@ebyhr ebyhr requested review from wendigo and hashhar March 29, 2024 07:19
hashhar
hashhar approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't tests catch this?

EDIT: Nevermind, after reading the issue I understand the problem.

@ebyhr ebyhr merged commit 342448c into trinodb:master Mar 29, 2024
44 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-minor-fix branch March 29, 2024 08:18
@github-actions github-actions bot added this to the 444 milestone Mar 29, 2024
@mosabua mosabua mentioned this pull request Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashhar hashhar hashhar approved these changes

@wendigo wendigo wendigo approved these changes

Assignees
No one assigned
Labels
iceberg Iceberg connector no-release-notes This pull request does not require release notes entry
Milestone
444
Development

Successfully merging this pull request may close these issues.

JsonProperty value is different from variable name in Iceberg
3 participants
@ebyhr @wendigo @hashhar