Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip AdaptivePartitioning from running multiple times #21318

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

gaurav8297
Copy link
Member

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 29, 2024
@gaurav8297 gaurav8297 requested a review from losipiuk March 29, 2024 00:13
@gaurav8297 gaurav8297 requested review from losipiuk and sopel39 March 29, 2024 21:01
This is to avoid re-planning since currently we
apply this rule on the entire plan. Once,
we have a granular way of applying this rule,
we can remove this check.
@gaurav8297 gaurav8297 force-pushed the fix_adaptive_planning_bug branch from 548d3be to 8288e3b Compare April 1, 2024 02:43
@losipiuk losipiuk merged commit 24e3082 into trinodb:master Apr 2, 2024
94 of 95 checks passed
@github-actions github-actions bot added this to the 444 milestone Apr 2, 2024
@losipiuk
Copy link
Member

losipiuk commented Apr 3, 2024

@gaurav8297 Is it only to fix Number of stages in the query (152) exceeds the allowed maximum (150) (#21153) ?

Or could the lack of fix also cause timeouts? We observed (TestHiveRuntimeAdaptivePartitioningFaultTolerantExecutionJoinQueries.testInnerJoinWithEmptyBuildSide » Timeout testInnerJoinWithEmptyBuildSide() timed out after 120 seconds in couple of runs).

@gaurav8297
Copy link
Member Author

Or could the lack of fix also cause timeouts? We observed (TestHiveRuntimeAdaptivePartitioningFaultTolerantExecutionJoinQueries.testInnerJoinWithEmptyBuildSide » Timeout testInnerJoinWithEmptyBuildSide() timed out after 120 seconds in couple of runs).

I think it can also cause timeout since by adding new stages, it can increase the execution time.

@mosabua
Copy link
Member

mosabua commented Apr 3, 2024

I assume no release notes @losipiuk .. please use the template or the label...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants