Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 21 for local development #21312

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Mar 28, 2024

.java-version is no longer used as a source of the information
which JDK will be installed in the docker image. From now on, this will
be only used to describe required JDK version for local development.

No release notes needed.

.java-version is no longer used as a source of the information
which JDK will be installed in the docker image. From now on, this will
be only used to describe required JDK version for local development.
@cla-bot cla-bot bot added the cla-signed label Mar 28, 2024
@wendigo wendigo requested a review from losipiuk March 28, 2024 15:33
@wendigo wendigo requested a review from findepi March 28, 2024 16:00
@wendigo wendigo added the no-release-notes This pull request does not require release notes entry label Mar 28, 2024
@wendigo wendigo merged commit 005766b into master Mar 28, 2024
10 of 103 checks passed
@wendigo wendigo deleted the serafin/java-version-21 branch March 28, 2024 16:18
@github-actions github-actions bot added this to the 444 milestone Mar 28, 2024
@mosabua
Copy link
Member

mosabua commented Mar 28, 2024

We should add a comment or so about this .. maybe in the PR when you update to 22

@wendigo
Copy link
Contributor Author

wendigo commented Mar 28, 2024

@mosabua it reverts to a previous state so it's a no-op for the next release

@mosabua
Copy link
Member

mosabua commented Mar 29, 2024

I know .. I meant we should add a comment in the file or elsewhere that it only affects local development and nothing else... and you can do that when we update the file to 22...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

4 participants