Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use G1GC for product tests #21311

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Always use G1GC for product tests #21311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions testing/trino-product-tests-launcher/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,8 +279,7 @@
<groupId>org.skife.maven</groupId>
<artifactId>really-executable-jar-maven-plugin</artifactId>
<configuration>
<!-- Force Parallel GC to ensure MaxHeapFreeRatio is respected -->
<flags>-Xmx256m -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=50</flags>
<flags>-Xmx256m</flags>
<classifier>executable</classifier>
</configuration>
<executions>
Expand Down
4 changes: 0 additions & 4 deletions ...ino-product-tests-launcher/src/main/java/io/trino/tests/product/launcher/cli/TestRun.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,6 @@ private Environment getEnvironment()
.add(
jdkProvider.getJavaCommand(),
"-Xmx1g",
// Force Parallel GC to ensure MaxHeapFreeRatio is respected
"-XX:+UseParallelGC",
"-XX:MinHeapFreeRatio=10",
"-XX:MaxHeapFreeRatio=50",
"-Djava.util.logging.config.file=/docker/presto-product-tests/conf/tempto/logging.properties",
"-Duser.timezone=Asia/Kathmandu",
// Tempto has progress logging built in
Expand Down
1 change: 0 additions & 1 deletion ...ources/docker/presto-product-tests/conf/environment/multinode/multinode-master-jvm.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
-server
# coordinator is not a worker
-Xmx1G
-XX:+UseParallelGC
-XX:+ExitOnOutOfMemoryError
-XX:+HeapDumpOnOutOfMemoryError
-XX:-OmitStackTraceInFastThrow
Expand Down
1 change: 0 additions & 1 deletion ...ources/docker/presto-product-tests/conf/environment/multinode/multinode-worker-jvm.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
-server
-Xmx2G
-XX:+UseParallelGC
-XX:+ExitOnOutOfMemoryError
-XX:+HeapDumpOnOutOfMemoryError
-XX:-OmitStackTraceInFastThrow
Expand Down