Keep consistent the ordering of partition values to the partition keys #21241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
commented
Mar 25, 2024
...in/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakePageSourceProvider.java
Show resolved
Hide resolved
ebyhr
reviewed
Mar 25, 2024
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConnectorTest.java
Outdated
Show resolved
Hide resolved
jayzzh
approved these changes
Mar 27, 2024
jayzzh
reviewed
Mar 27, 2024
...in/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakePageSourceProvider.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-keep-partition-values-ordering
branch
2 times, most recently
from
179e9d8 to
290e303
Compare
jayzzh
reviewed
Mar 27, 2024
...in/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakePageSourceProvider.java
Outdated
Show resolved
Hide resolved
jayzzh
approved these changes
Mar 27, 2024
findinpath
force-pushed
the
findinpath/delta-keep-partition-values-ordering
branch
from
290e303 to
58aea0f
Compare
The previous logic was depending on the ordering of the columns in the schema of the table and not on the ordering of the partition keys which could have produced inconsistent partition values for tables with composed partition keys.
ebyhr
force-pushed
the
findinpath/delta-keep-partition-values-ordering
branch
from
58aea0f to
4ae73be
Compare
ebyhr
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous logic was depending on the ordering of the columns in the schema of the table and not on the ordering of the partition keys which could have produced inconsistent partition values for tables with composed partition keys.
Relates to finding https://github.com/trinodb/trino/pull/20993/files#r1536703816
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: