Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test time/timestamp date_diff, date_add, date_trunc with all units #21222

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 24, 2024

No description provided.

@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Mar 24, 2024
@cla-bot cla-bot bot added the cla-signed label Mar 24, 2024
findepi added 2 commits March 24, 2024 22:02
Test `date_diff`, `date_add` and `date_trunc` functions on TIME and TIME
WITH TIME ZONE types with units that are invalid. Also make error
reporting consistent.
Test `date_diff` and `date_add` functions on TIMESTAMP and TIMESTAMP
WITH TIME ZONE types with all valid units. Existing tests exercised only
some valid units.
@findepi findepi force-pushed the findepi/date-funcs branch from a854743 to acc654b Compare March 25, 2024 05:02
@findepi findepi requested review from martint and wendigo March 25, 2024 05:02
@findepi findepi merged commit b787b17 into trinodb:master Mar 25, 2024
95 checks passed
@findepi findepi deleted the findepi/date-funcs branch March 25, 2024 19:15
@github-actions github-actions bot added this to the 444 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry test
Development

Successfully merging this pull request may close these issues.

2 participants