Clean up IR Subscript #21217
Merged
Clean up IR Subscript #21217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
iceberg
dain
approved these changes
Mar 23, 2024
wendigo
reviewed
Mar 23, 2024
| @@ -883,36 +880,20 @@ protected Object visitRow(Row node, Object context) | |||
| } | |||
|
|
|||
| @Override | |||
| protected Object visitSubscript(Subscript node, Object context) | |||
| protected Object visitSubscript(FieldReference node, Object context) | |||
There was a problem hiding this comment.
shouldn't this method be renamed to visitFieldDereference ?
It only applies to expressions of Row type
It's a fixed compile-time value, so it's unnecessary to represent it as an arbitrary Expression. That's a vestige from when it used to be named Subscript and represented array accesses, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename to FieldReference and make the field an integer instead of an IR expression.
This node is only relevant for expression of Row type, and the field is known at construction time.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.