Fix planning of subscript and like #21215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Mar 22, 2024
core/trino-main/src/main/java/io/trino/sql/planner/ConnectorExpressionTranslator.java
Show resolved
Hide resolved
martint
force-pushed
the
ir-subscript
branch
2 times, most recently
from
134c1af to
ead38a8
Compare
$like was defined for varchar, not for varchar(n), so calls required a intervening cast to be formulated properly. When the argument signature is varchar(n), calls work for both varchar and varchar(n) without additional casts due to a quirk in how the type inference and resolution algorithm works. The proper fix would be to add both variants, but due to the issue in the type inferencer, it causes failures due to perceived ambiguity during resolution. Also, add casts for the pattern/escape arguments to match the expected varchar type.
wendigo
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.