Add pushdown docs for Snowflake #21214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
commented
Mar 22, 2024
|
Update.. I looked a bit at the code and I think the aggregate pushdown list is better now .. still not sure about other stuff |
mosabua
commented
Mar 22, 2024
| ```{include} pushdown-correctness-behavior.fragment | ||
| ``` | ||
|
|
||
| ```{include} join-pushdown-enabled-true.fragment |
There was a problem hiding this comment.
removed this since I am pretty sure cost based join pushdown is not supported
mosabua
force-pushed
the
snowpush
branch
2 times, most recently
from
dfcf6db to
e478c92
Compare
mosabua
commented
Mar 22, 2024
ebyhr
reviewed
Mar 23, 2024
|
Added topn and limit back to the docs since a recent PR added topn and another activated limit testing.. so is join pushdown supported? |
ebyhr
approved these changes
Mar 25, 2024
|
Thanks @ebyhr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently I just copied the section from PostgreSQL connector to start a discussion what is actually implemented. Only one I know of is avg for bigint since that was implemented in the linked PR. Are there others already there that are just not yet documented @dprophet @yuuteng @ebyhr
Another PR merged and added topn, and one activated limit testing. So I added those. Anyone if join pushdown is supported?
Additional context and related issues
avgaggregation pushdown onbiginttype in Snowflake #21148Release notes
(x) This is not user-visible or is docs only, and no release notes are required.