Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize Symbol names for unambiguous plans #21200

Closed
wants to merge 1 commit into from
Closed

Sanitize Symbol names for unambiguous plans #21200

wants to merge 1 commit into from

Conversation

findepi
Copy link
Member

@findepi findepi commented Mar 22, 2024

No description provided.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Mar 22, 2024
@findepi findepi requested review from martint and sopel39 March 22, 2024 11:20
@cla-bot cla-bot bot added the cla-signed label Mar 22, 2024
@findepi findepi force-pushed the findepi/sanitize-symbol-names-for-unambiguous-plans-8ca5b5 branch from 16fcda2 to 5c19d1c Compare March 22, 2024 11:25
@sopel39
Copy link
Member

sopel39 commented Mar 22, 2024

I don't think it's required. I think it would be better to escape names that don't match pattern

martint
martint requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@martint martint left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plans are structurally unambiguous already. Also, the names are generated by SymbolAllocator, so already guaranteed to have a limited set of characters (or it should be done there).

Here's an alternative: #21204

@findepi
Copy link
Member Author

findepi commented Mar 22, 2024

Also, the names are generated by SymbolAllocator, so already guaranteed to have a limited set of characters (or it should be done there).

my PR also does it there

Plans are structurally unambiguous already

Plans are, agreed.
But, should we have symbols with weird names, the EXPLAIN output can be less unambiguous than desired.

@findepi findepi closed this Mar 22, 2024
@findepi findepi deleted the findepi/sanitize-symbol-names-for-unambiguous-plans-8ca5b5 branch March 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martint martint martint requested changes

@sopel39 sopel39 Awaiting requested review from sopel39

Assignees
No one assigned
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@findepi @sopel39 @martint