Wrap IR IN value list in brackets #21197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
added
the
no-release-notes
Otherwise invalid SQL is produced when formatting
sopel39
force-pushed
the
ks/fix_formatting
branch
from
c962a71 to
b1a5f0f
Compare
findepi
approved these changes
Mar 22, 2024
|
@wendigo I think some coverage might be dropped when adding IR. Also it might not be needed per se for corectness but it's obviously wrong from SQL perspective. |
|
also obviously wrong from explain readability perspective |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise invalid SQL is produced when formatting
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.