Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom header name for authorization in Prometheus #21187

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

amitkharb
Copy link
Contributor

@amitkharb amitkharb commented Mar 21, 2024

Description

Fixes #20659

Additional context and related issues

Allowing users to use a custom header for authorization of prometheus endpoint

Current code only support Authorization http header, just adding a new configuration property to allow a custom header name

Release notes

(X ) Release notes are required, with the following suggested text:

# Prometheus
* Add support for a custom authorization header name.({issue}`21187`)

@amitkharb
Copy link
Contributor Author

All the changes from #20939 has been applied here.
I could not get the other PR cla-bot signed.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mosabua mosabua merged commit fcfdaef into trinodb:master Mar 21, 2024
20 checks passed
@github-actions github-actions bot added this to the 443 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Make the http header customisable for trino-prometheus connector
3 participants