Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language function manager cleanup #21151

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

dain
Copy link
Member

@dain dain commented Mar 19, 2024

Description

  • Remove unnecessary declaration of function dependencies for language functions
  • Simplify resolution of language funcitons
  • Simplify propagation of language functions to workers
  • Use IrRoutine hash instead of SQL hash for FunctionId

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Mar 19, 2024
@dain dain force-pushed the language-function-manager-cleanup branch 2 times, most recently from 230eb91 to cd3c3fe Compare March 19, 2024 17:47
@dain dain requested review from electrum and martint March 19, 2024 17:54
@wendigo
Copy link
Contributor

wendigo commented Mar 25, 2024

@dain can you rebase?

@dain dain force-pushed the language-function-manager-cleanup branch from cd3c3fe to ca9ff19 Compare April 2, 2024 06:39
@dain dain force-pushed the language-function-manager-cleanup branch from ca9ff19 to 0a8e322 Compare April 2, 2024 06:47
@dain dain merged commit bbaa1ee into trinodb:master Apr 2, 2024
96 checks passed
@dain dain deleted the language-function-manager-cleanup branch April 2, 2024 16:00
@github-actions github-actions bot added this to the 444 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants