Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for count distinct pushdown for snowflake #21130

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add support for count distinct pushdown for snowflake #21130

merged 1 commit into from
Mar 28, 2024

Conversation

chenjian2664
Copy link
Contributor

@chenjian2664 chenjian2664 commented Mar 18, 2024

Release notes

(x) Release notes are required, with the following suggested text:

# Snowflake
* Add support for [aggregation pushdown](aggregation-pushdown) of the `count(distinct)` function. ({issue}`21130`)

@cla-bot cla-bot bot added the cla-signed label Mar 18, 2024
@chenjian2664 chenjian2664 self-assigned this Mar 18, 2024
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests - see PostgreSQL connector for what to test and where.

@ebyhr
Copy link
Member

ebyhr commented Mar 27, 2024

Could you rebase on master to resolve conflicts?

@ebyhr
Copy link
Member

ebyhr commented Mar 27, 2024

/test-with-secrets sha=191ca97f5fd58187552b4c14c405a7c2896c637c

Copy link

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8447629959

@ebyhr
Copy link
Member

ebyhr commented Mar 28, 2024

Could you rebase on master to resolve conflicts?

@ebyhr
Copy link
Member

ebyhr commented Mar 28, 2024

/test-with-secrets sha=d917182dfc5684c36758cca555353ed4f765d589

Copy link

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8460542297

@ebyhr
Copy link
Member

ebyhr commented Mar 28, 2024

/test-with-secrets sha=e8503af4d4b8bcedce5f77abf1d955d5ad3e555b

Copy link

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8460568445

@@ -66,10 +66,8 @@ protected SqlExecutor onRemoteDatabase()
protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior)
{
return switch (connectorBehavior) {
case SUPPORTS_AGGREGATION_PUSHDOWN -> true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenjian2664 I reverted your change as SUPPORTS_AGGREGATION_PUSHDOWN and SUPPORTS_PREDICATE_PUSHDOWN are true by default.

@ebyhr ebyhr merged commit b52e3f6 into trinodb:master Mar 28, 2024
19 checks passed
@github-actions github-actions bot added this to the 444 milestone Mar 28, 2024
@chenjian2664 chenjian2664 deleted the sn_pd_count_dis branch March 28, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants