-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for count distinct pushdown for snowflake #21130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add tests - see PostgreSQL connector for what to test and where.
plugin/trino-snowflake/src/test/java/io/trino/plugin/snowflake/TestSnowflakeConnectorTest.java
Outdated
Show resolved
Hide resolved
Could you rebase on master to resolve conflicts? |
/test-with-secrets sha=191ca97f5fd58187552b4c14c405a7c2896c637c |
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8447629959 |
Could you rebase on master to resolve conflicts? |
/test-with-secrets sha=d917182dfc5684c36758cca555353ed4f765d589 |
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8460542297 |
/test-with-secrets sha=e8503af4d4b8bcedce5f77abf1d955d5ad3e555b |
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/8460568445 |
@@ -66,10 +66,8 @@ protected SqlExecutor onRemoteDatabase() | |||
protected boolean hasBehavior(TestingConnectorBehavior connectorBehavior) | |||
{ | |||
return switch (connectorBehavior) { | |||
case SUPPORTS_AGGREGATION_PUSHDOWN -> true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenjian2664 I reverted your change as SUPPORTS_AGGREGATION_PUSHDOWN and SUPPORTS_PREDICATE_PUSHDOWN are true by default.
Release notes
(x) Release notes are required, with the following suggested text: