Add RemoteLogTracingEvent to allow tracing the event happen or not #21127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 18, 2024
Closed
hashhar
reviewed
Mar 25, 2024
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/RemoteLogTracingEvent.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/RemoteLogTracingEvent.java
Outdated
Show resolved
Hide resolved
| .ifPresent(remoteDatabaseEvent -> tracingEvents.forEach(tracingEvent -> tracingEvent.accept(remoteDatabaseEvent))); | ||
| } | ||
|
|
||
| private Optional<RemoteDatabaseEvent> buildEvent(OutputFrame outputFrame) |
There was a problem hiding this comment.
Is getRemoteDatabaseEvents now safe to remove?
There was a problem hiding this comment.
There are multiple references of the getRemoteDatabaseEvents, I think it's not so easy to remove the method directly.
Thanks for the review. |
chenjian2664
changed the title
Co-Authored-By: Ashhar Hasan <[email protected]>
|
Error: TestHiveRuntimeAdaptivePartitioningFaultTolerantExecutionJoinQueries.testInnerJoinWithEmptyProbeSide » Timeout testInnerJoinWithEmptyProbeSide() timed out after 120 seconds |
hashhar
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
@Praveen2112 / @kokosing do you want to take a look before I merge?
Praveen2112
approved these changes
Mar 26, 2024
hashhar
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add RemoteTracingEvent to support check a database event(in log) happened or not without grab all logs from container at a time.
Update Postgresql testCancellation test to use RemoteTracingEvent.
Additional context and related issues
https://trinodb.slack.com/archives/CP1MUNEUX/p1710496005499909
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.