Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly describe how selector rules are applied #20828

Conversation

gparrello
Copy link

Description

Expand documentation on Resource Group selector rules. Behaviour of selector rules is implied by the example provided in the readme, yet it can be explicitly mentioned for clarity.

Additional context and related issues

Related conversation from Trino Slack community.

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Behaviour of selector rules is implied by the example provided in the readme, yet it can be explicitly mentioned for clarity.
Copy link

cla-bot bot commented Feb 23, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Feb 23, 2024
@gparrello gparrello changed the title Explicitly describe how selector rules are apply Explicitly describe how selector rules are applied Feb 23, 2024
@hashhar hashhar requested a review from mosabua February 23, 2024 18:22
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically accurate.

@mosabua please take a look.

@mosabua
Copy link
Member

mosabua commented Feb 27, 2024

Please adjust to feedback and submit a CLA (if you did already thats fine .. it will be a bit until we process)

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Mar 19, 2024
@mosabua
Copy link
Member

mosabua commented Mar 19, 2024

@cla-bot check

Copy link

cla-bot bot commented Mar 19, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Mar 19, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mosabua
Copy link
Member

mosabua commented Mar 19, 2024

Replaced by #21165

@mosabua mosabua closed this Mar 19, 2024
@gparrello
Copy link
Author

I apologize for the lack of response, need to review how I am receiving notifications from GitHub for this repo. Thanks for updating the docs in #21165 !

@gparrello gparrello deleted the docs/describe-resource-group-selector-rules-behavior branch March 30, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants