Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run testTimestampInsertCompatibility only in OSS Delta #20484

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Jan 28, 2024

Description

Follow-up of #20420.
Running the test with OSS Delta Lake seems sufficient.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 28, 2024
@ebyhr ebyhr requested review from alexjo2144, wendigo and findepi and removed request for wendigo January 28, 2024 09:03
@findepi
Copy link
Member

findepi commented Jan 31, 2024

didn't #20420 show that results may be DBR version dependent?

Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but see previous comment/q

Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 21, 2024
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Mar 14, 2024
@mosabua
Copy link
Member

mosabua commented Mar 14, 2024

I think this should be reopened and probably merged @ebyhr and @findepi

@mosabua mosabua reopened this Mar 14, 2024
@github-actions github-actions bot removed the stale label Mar 15, 2024
@ebyhr
Copy link
Member Author

ebyhr commented Mar 25, 2024

didn't #20420 show that results may be DBR version dependent?

The expected result should be same regardless of Databricks version. There's no benefit to catch Databricks bug in this case.

@ebyhr ebyhr merged commit 25690ea into trinodb:master Mar 25, 2024
82 checks passed
@ebyhr ebyhr deleted the ebi/delta-timestamp branch March 25, 2024 01:58
@github-actions github-actions bot added this to the 444 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants