Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document millisecond unit for date_trunc function #20440

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

hirolee88
Copy link
Contributor

@hirolee88 hirolee88 commented Jan 22, 2024

Description

Improve The date_trunc function documentation add unit millisecond

Additional context and related issues

Fixes #20427

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jan 22, 2024
@github-actions github-actions bot added the docs label Jan 22, 2024
@hirolee88 hirolee88 requested a review from ebyhr January 22, 2024 12:30
@hashhar hashhar requested a review from mosabua January 22, 2024 12:35
@ebyhr
Copy link
Member

ebyhr commented Jan 22, 2024

Improve The date_trunc function documentation add unit millisecond

Could you change the commit title to Document millisecond unit for date_trunc function?

@hirolee88 hirolee88 changed the title Improve The date_trunc function documentation add unit millisecond Document millisecond unit for date_trunc function Jan 22, 2024
@hirolee88
Copy link
Contributor Author

Improve The date_trunc function documentation add unit millisecond

Could you change the commit title to Document millisecond unit for date_trunc function?

done

@hirolee88 hirolee88 self-assigned this Jan 22, 2024
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hirolee88

@mosabua mosabua merged commit 51517b1 into trinodb:master Jan 22, 2024
9 checks passed
@github-actions github-actions bot added this to the 437 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

date_trunc has millisecond support but missing in the doc
3 participants