Fix adaptation of nullable return to BLOCK_BUILDER #20429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
approved these changes
Jan 20, 2024
|
💥 ! |
When adapting a nullable function to a BLOCK_BUILDER return, a null must be appended when the function return value is null. Fixes trinodb#18456 Co-authored-by: Dain Sundstrom <[email protected]>
dain
force-pushed
the
fix-nullable-to-block-builder
branch
from
c372c72 to
a68eac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adapting a nullable function to a BLOCK_BUILDER return, a null must be appended when the function return value is null.
Fixes #18456
Release notes
(x) Release notes are required, with the following suggested text: