Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade depedencies #20405

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Upgrade depedencies #20405

merged 6 commits into from
Jan 22, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jan 17, 2024

No description provided.

@wendigo wendigo requested a review from losipiuk January 17, 2024 20:14
@cla-bot cla-bot bot added the cla-signed label Jan 17, 2024
@wendigo wendigo requested review from ebyhr and hashhar January 17, 2024 20:19
@ebyhr
Copy link
Member

ebyhr commented Jan 17, 2024

Could you confirm SingleStore CI failure?

Error:  Failures: 
Error:    TestSingleStoreConnectorTest>BaseConnectorTest.testAddColumn:2275->AbstractTestQueryFramework.assertQuery:348 Execution of 'actual' query 20240117_203121_00714_em7m3 failed: SELECT * FROM test_add_column_fnlcuoyzuk
Error:  Errors: 
Error:    TestSingleStoreConnectorTest.testAddNotNullColumn:276->AbstractTestQueryFramework.query:328->AbstractTestQueryFramework.query:333 » QueryFailed Data type LONGBLOB (not binary) cannot be decoded as Blob
Error:    TestSingleStoreConnectorTest>BaseConnectorTest.testAddNotNullColumnToEmptyTable:2355->AbstractTestQueryFramework.query:328->AbstractTestQueryFramework.query:333 » QueryFailed Data type LONGBLOB (not binary) cannot be decoded as Blob
Error:    TestSingleStoreConnectorTest>BaseConnectorTest.testVarcharCastToDateInPredicate:605->AbstractTestQueryFramework.query:328->AbstractTestQueryFramework.query:333 » QueryFailed Data type LONGBLOB (not binary) cannot be decoded as Blob
Error:    TestSingleStoreTypeMapping.testSingleStoreCreatedParameterizedVarchar:563 » QueryFailed Data type TINYBLOB (not binary) cannot be decoded as Blob
Error:    TestSingleStoreTypeMapping.testSingleStoreCreatedParameterizedVarcharUnicode:581 » QueryFailed Data type TINYBLOB (not binary) cannot be decoded as Blob
Error:    TestSingleStoreTypeMapping.testTrinoCreatedParameterizedVarchar:549 » QueryFailed Data type BLOB (not binary) cannot be decoded as Blob

@wendigo wendigo force-pushed the serafin/jan-17-updates branch from 89fb5dd to c7fbd37 Compare January 18, 2024 11:47
@wendigo
Copy link
Contributor Author

wendigo commented Jan 18, 2024

@ebyhr ptal

@wendigo wendigo force-pushed the serafin/jan-17-updates branch from c7fbd37 to 55708d4 Compare January 18, 2024 14:09
@wendigo
Copy link
Contributor Author

wendigo commented Jan 22, 2024

@ebyhr ping

@wendigo wendigo force-pushed the serafin/jan-17-updates branch from 55708d4 to 303311b Compare January 22, 2024 11:25
@wendigo
Copy link
Contributor Author

wendigo commented Jan 22, 2024

Rebased

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: " Update singlestore-jdbc-client to 1.2.1 ".

It seems

// we don't want to interpret tinyInt type (with cardinality as 2) as boolean/bit
connectionProperties.setProperty("tinyInt1isBit", "false");
is redundant now. The driver has changed behaviour in memsql/S2-JDBC-Connector@db0115a.

Nevermind, our config applies to tinyints, not bits being treated as booleans.

@wendigo wendigo merged commit ce269c5 into master Jan 22, 2024
101 of 102 checks passed
@wendigo wendigo deleted the serafin/jan-17-updates branch January 22, 2024 12:27
@github-actions github-actions bot added this to the 437 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants