-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade depedencies #20405
Merged
Merged
Upgrade depedencies #20405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you confirm SingleStore CI failure?
|
wendigo
force-pushed
the
serafin/jan-17-updates
branch
from
January 18, 2024 11:47
89fb5dd
to
c7fbd37
Compare
@ebyhr ptal |
wendigo
force-pushed
the
serafin/jan-17-updates
branch
from
January 18, 2024 14:09
c7fbd37
to
55708d4
Compare
@ebyhr ping |
wendigo
force-pushed
the
serafin/jan-17-updates
branch
from
January 22, 2024 11:25
55708d4
to
303311b
Compare
Rebased |
hashhar
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: " Update singlestore-jdbc-client to 1.2.1 ".
It seems
Lines 56 to 57 in 469cc1f
// we don't want to interpret tinyInt type (with cardinality as 2) as boolean/bit | |
connectionProperties.setProperty("tinyInt1isBit", "false"); |
Nevermind, our config applies to tinyints, not bits being treated as booleans.
hashhar
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.