Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-deprecated Subject.callAs instead of doAs #20322

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Use non-deprecated Subject.callAs instead of doAs #20322

merged 2 commits into from
Jan 12, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jan 10, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 10, 2024
@wendigo wendigo force-pushed the serafin/use-non-deprecated-call-as branch from 6d5f022 to 07e1d29 Compare January 11, 2024 10:57
@wendigo wendigo requested a review from ebyhr January 11, 2024 10:58
@github-actions github-actions bot added tests:hive hive Hive connector labels Jan 11, 2024
@wendigo
Copy link
Contributor Author

wendigo commented Jan 11, 2024

CI hit #20324

@wendigo
Copy link
Contributor Author

wendigo commented Jan 11, 2024

@ebyhr I've added two more cases

@wendigo wendigo requested a review from hashhar January 11, 2024 12:10
@hashhar hashhar requested review from Praveen2112 and removed request for hashhar January 11, 2024 12:39
@wendigo
Copy link
Contributor Author

wendigo commented Jan 11, 2024

Right now in JDK 21, it calls the previous doAs(PriviligedAction<>) so there is no behaviour change. In future releases, when SecurityManager is removed, the new callAs method will change it's implementation and 'doAs` will be removed

@wendigo wendigo force-pushed the serafin/use-non-deprecated-call-as branch from 07e1d29 to 5649d31 Compare January 12, 2024 10:54
@wendigo wendigo merged commit bbf76b3 into master Jan 12, 2024
92 of 95 checks passed
@wendigo wendigo deleted the serafin/use-non-deprecated-call-as branch January 12, 2024 13:17
@github-actions github-actions bot added this to the 437 milestone Jan 12, 2024
@colebow colebow mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveen2112 Praveen2112 Praveen2112 approved these changes

@ebyhr ebyhr ebyhr approved these changes

@grantatspothero grantatspothero Awaiting requested review from grantatspothero

@electrum electrum Awaiting requested review from electrum

Assignees
No one assigned
Labels
cla-signed hive Hive connector
Milestone
437
Development

Successfully merging this pull request may close these issues.
3 participants
@wendigo @ebyhr @Praveen2112