Conditional rewrites in JDBC complex expression pushdown #20318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/conditional-rewrite
branch
from
2408533 to
d41f1ae
Compare
|
|
wendigo
reviewed
Jan 10, 2024
| .map("$less_than_or_equal(left: collatable_type, right: collatable_type)").to("left <= right COLLATE \"C\"") | ||
| .map("$greater_than(left: collatable_type, right: collatable_type)").to("left > right COLLATE \"C\"") | ||
| .map("$greater_than_or_equal(left: collatable_type, right: collatable_type)").to("left >= right COLLATE \"C\"") | ||
| .when(pushdownWithCollateEnabled).map("$less_than(left: collatable_type, right: collatable_type)").to("left < right COLLATE \"C\"") |
findepi
force-pushed
the
findepi/conditional-rewrite
branch
from
d41f1ae to
500d97f
Compare
|
rebased, ready to review. ptal |
findepi
added
the
no-release-notes
wendigo
reviewed
Jan 10, 2024
plugin/trino-postgresql/src/main/java/io/trino/plugin/postgresql/PostgreSqlClient.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
Jan 10, 2024
Add support for conditional rewrites in `JdbcConnectorExpressionRewriterBuilder`. This allows merging `PostgreSqlClient`'s two different rewrite objects into one.
findepi
force-pushed
the
findepi/conditional-rewrite
branch
from
500d97f to
e533200
Compare
hashhar
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for conditional rewrites in
JdbcConnectorExpressionRewriterBuilder.This allows merging
PostgreSqlClient's two different rewrite objects into one.