Unignore re2j dependency conflicts #20244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`trino-re2j` is a fork of `com.google.re2j:re2j`. The forks diverged over time. It is not safe to ignore this dependency conflict e.g. because `com.google` version has `com.google.re2j.Pattern.matcher` accepting `CharSequence` or `byte[]` while Trino version accepts only `Slice`. They cannot be used interchangeably at all.
findepi
requested review from
electrum,
wendigo,
losipiuk,
elonazoulay and
ebyhr
findepi
commented
Dec 29, 2023
Comment on lines
-2437
to
-2451
| <exception> | ||
| <conflictingDependencies> | ||
| <dependency> | ||
| <groupId>com.google.re2j</groupId> | ||
| <artifactId>re2j</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.trino</groupId> | ||
| <artifactId>re2j</artifactId> | ||
| </dependency> | ||
| </conflictingDependencies> | ||
| <packages> | ||
| <package>com.google.re2j</package> | ||
| </packages> | ||
| </exception> |
There was a problem hiding this comment.
Main change. You can start reviewing from here.
|
CI #20245 (re-running) |
|
CI #15187 |
wendigo
approved these changes
Dec 29, 2023
findepi
deleted the
findepi/unignore-re2j-dependency-conflicts-2cec2f
branch
|
followed-up trinodb/re2j#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trino-re2jis a fork ofcom.google.re2j:re2j. The forks diverged over time. It is not safe to ignore this dependency conflict e.g. becausecom.googleversion hascom.google.re2j.Pattern.matcheracceptingCharSequenceorbyte[]while Trino version accepts onlySlice. They cannot be used interchangeably at all.