Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the failure when building trino-server alone #20230

Merged

Conversation

athultr1997
Copy link
Contributor

@athultr1997 athultr1997 commented Dec 27, 2023

Added a dummy test in trino-server to prevent failures when trying to build since there are no tests in the project.

Description

Fixes #19798 by adding a dummy test.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Dec 27, 2023
@athultr1997 athultr1997 self-assigned this Dec 27, 2023
@athultr1997 athultr1997 requested a review from findepi December 27, 2023 14:50
@findepi
Copy link
Member

findepi commented Dec 29, 2023

@athultr1997 thank you for your PR!

would it also work to add a dummy test class, like in some other modules, see

?

Added a dummy test in trino-server
@athultr1997 athultr1997 force-pushed the fix-building-trino-server-alone branch from dc822f7 to 7f0afc8 Compare January 1, 2024 09:20
@athultr1997
Copy link
Contributor Author

@athultr1997 thank you for your PR!

would it also work to add a dummy test class, like in some other modules, see

?

@findepi Have added the dummy test

@electrum electrum merged commit 75854f4 into trinodb:master Jan 5, 2024
42 checks passed
@github-actions github-actions bot added this to the 436 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Building trino-server alone fails: No tests to run!
4 participants