Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support translation of JsonPathType to ConnectorExpression #20218

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

assaf2
Copy link
Member

@assaf2 assaf2 commented Dec 24, 2023

Description

Support translation of JsonPathType (which is not part of SPI) to ConnectorExpression in order to support pushdown of functions like json_extract_scalar.

Release notes

( X ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@assaf2 assaf2 requested a review from findepi December 24, 2023 11:58
@cla-bot cla-bot bot added the cla-signed label Dec 24, 2023
@assaf2 assaf2 self-assigned this Dec 24, 2023
@assaf2 assaf2 marked this pull request as draft December 25, 2023 15:34
@findepi
Copy link
Member

findepi commented Dec 29, 2023

The TestPredicatePushdown>AbstractPredicatePushdownTest.testDoesNotCreatePredicateFromInferredPredicate: failure looks related.

@assaf2 assaf2 force-pushed the assaf2/os-JsonPathType branch from c0ea459 to f647e29 Compare December 31, 2023 08:10
@assaf2
Copy link
Member Author

assaf2 commented Dec 31, 2023

The TestPredicatePushdown>AbstractPredicatePushdownTest.testDoesNotCreatePredicateFromInferredPredicate: failure looks related.

Rebase fixed the issue

@assaf2 assaf2 force-pushed the assaf2/os-JsonPathType branch from c20ef72 to d6dd9f9 Compare January 10, 2024 08:52
@assaf2 assaf2 marked this pull request as ready for review January 10, 2024 14:38
@findepi findepi merged commit 931e549 into trinodb:master Jan 10, 2024
88 checks passed
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jan 10, 2024
@github-actions github-actions bot added this to the 436 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants