Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust logging level to debug #20214

Merged
merged 3 commits into from
Dec 22, 2023
Merged

Adjust logging level to debug #20214

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca78645
Adjust logging level to debug
martint Dec 22, 2023
ea3e8b2
Fix formatting
martint Dec 22, 2023
a7afbd6
Remove unnecessary calls to toString()
martint Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions core/trino-main/src/main/java/io/trino/server/remotetask/TaskInfoFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,16 +251,14 @@ synchronized void updateTaskInfo(TaskInfo newTaskInfo)
TaskStatus newRemoteTaskStatus = newTaskInfo.getTaskStatus();

if (!newRemoteTaskStatus.getTaskId().equals(taskId)) {
log.warn("Task ID mismatch on remote task status. Member task ID is %s, but remote task ID is %s. This will confuse finalTaskInfo listeners.",
taskId.toString(), newRemoteTaskStatus.getTaskId().toString());
log.debug("Task ID mismatch on remote task status. Member task ID is %s, but remote task ID is %s. This will confuse finalTaskInfo listeners.", taskId, newRemoteTaskStatus.getTaskId());
}

if (localTaskStatus.getState().isDone() && newRemoteTaskStatus.getState().isDone() && localTaskStatus.getState() != newRemoteTaskStatus.getState()) {
// prefer local
newTaskInfo = newTaskInfo.withTaskStatus(localTaskStatus);
if (!localTaskStatus.getTaskId().equals(taskId)) {
log.warn("Task ID mismatch on local task status. Member task ID is %s, but status-fetcher ID is %s. This will confuse finalTaskInfo listeners.",
taskId.toString(), newRemoteTaskStatus.getTaskId().toString());
log.debug("Task ID mismatch on local task status. Member task ID is %s, but status-fetcher ID is %s. This will confuse finalTaskInfo listeners.", taskId, newRemoteTaskStatus.getTaskId());
}
}

Expand All @@ -271,7 +269,7 @@ synchronized void updateTaskInfo(TaskInfo newTaskInfo)
if (newTaskInfo.getTaskStatus().getState().isDone()) {
boolean wasSet = spoolingOutputStats.compareAndSet(null, newTaskInfo.getOutputBuffers().getSpoolingOutputStats().orElse(null));
if (wasSet && spoolingOutputStats.get() == null) {
log.warn("Task %s was updated to null spoolingOutputStats. Future calls to retrieveAndDropSpoolingOutputStats will fail.", taskId.toString());
log.debug("Task %s was updated to null spoolingOutputStats. Future calls to retrieveAndDropSpoolingOutputStats will fail.", taskId);
}
newTaskInfo = newTaskInfo.pruneSpoolingOutputStats();
}
Expand Down
Loading