Catch exception in sendUpdate #20202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To prevent bug similar to #19997 |
losipiuk
force-pushed
the
lo/safeSendUpdate
branch
from
622173c to
a78bafc
Compare
findepi
approved these changes
Dec 21, 2023
| sendUpdateUnsafe(); | ||
| } | ||
| catch (Throwable e) { | ||
| fatalUnacknowledgedFailure(new TrinoException(GENERIC_INTERNAL_ERROR, "unexpected error calling sendUpdate()", e)); |
There was a problem hiding this comment.
no need for TrinoException imo
can be just e
sopel39
reviewed
Dec 21, 2023
| try { | ||
| sendUpdateUnsafe(); | ||
| } | ||
| catch (Throwable e) { |
There was a problem hiding this comment.
Can we actually do that holistically? Maybe catch specific section in sendUpdate. It looks like sendUpdate might be touching some state (e.g updateErrorTracker#acquireRequestPermit)
There was a problem hiding this comment.
IDK what you mean by that
There was a problem hiding this comment.
I looked at sendUpdate and it seems it's generally stateless.
I don't think the code after
martint
reviewed
Dec 21, 2023
core/trino-main/src/main/java/io/trino/server/remotetask/HttpRemoteTask.java
Outdated
Show resolved
Hide resolved
Catch exception in sendUpdate. Currently in case we get unexpected exception from that method query would fail as thread responsible for updating task state will terminate.
losipiuk
force-pushed
the
lo/safeSendUpdate
branch
from
a78bafc to
5730c02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: