Bump number of queryExecutor threads in tests #20160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
added
the
no-release-notes
findepi
approved these changes
Dec 19, 2023
| @@ -43,7 +43,7 @@ public static Map<String, String> getExtraProperties() | |||
| .put("exchange.deduplication-buffer-size", "1kB") | |||
| .put("fault-tolerant-execution-task-memory", "1GB") | |||
| // limit number of threads to detect potential thread leaks | |||
| .put("query.executor-pool-size", "10") | |||
| .put("query.executor-pool-size", "100") | |||
There was a problem hiding this comment.
not convinced the 100 still guarantees thread leak detection
maybe remove // limit number of threads to detect potential thread leaks comment if it is obsolete?
There was a problem hiding this comment.
You are probably right - but then I think we can just drop this property and keep default 1000
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
While by default number of queryExecutor threads is 1000 in tests we limitted it to 10. This values was too small though. If tests are run in parallel all threads may be consumed by long running jobs running EventDrivenFaultTolerantQueryScheduler.Scheduler#run. In such case we are not able to run Future callback which use same executor and are also needed for queries to progress. If that happens test queries would hang.
losipiuk
force-pushed
the
lo/bump-query-executor-size
branch
from
dfdf994 to
03c21fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While by default number of queryExecutor threads is 1000 in tests we limitted it to 10. This values was too small though. If tests are run in parallel all threads may be consumed by long running jobs running EventDrivenFaultTolerantQueryScheduler.Scheduler#run. In such case we are not able to run Future callback which use same executor and are also needed for queries to progress. If that happens test queries would hang.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: