Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirement to Oracle 19 #20141

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Dec 15, 2023

Description

Follow up to downgrade of JDBC driver, also fix links, adjusted requirements because we only test with 19 as min version.

Release notes

Not sure to be honest.. wdyt @wendigo .. no entry, normal entry, or even breaking change entry?

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@mosabua mosabua requested a review from wendigo December 15, 2023 20:45
@cla-bot cla-bot bot added the cla-signed label Dec 15, 2023
@github-actions github-actions bot added the docs label Dec 15, 2023
@wendigo
Copy link
Contributor

wendigo commented Dec 15, 2023

@mosabua no entry, Oracle 12 is no longer supported by Oracle

@mosabua
Copy link
Member Author

mosabua commented Dec 15, 2023

So are you approving this PR @wendigo ?

@wendigo wendigo merged commit 5fb1050 into trinodb:master Dec 15, 2023
9 checks passed
@github-actions github-actions bot added this to the 436 milestone Dec 15, 2023
@mosabua mosabua deleted the oracle19 branch February 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants