Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase GCLocker retries for Maven #20135

Conversation

findepi
Copy link
Member

@findepi findepi commented Dec 15, 2023

The build was observed failing with

Warning: [325.033s][warning][gc,alloc] mvn-builder-trino-parquet: Retried waiting for GCLocker too often allocating 4194306 words

on CI (https://github.com/trinodb/trino/actions/runs/7221312204/job/19676023973?pr=20134)

The build was observed failing with

    Warning: [325.033s][warning][gc,alloc] mvn-builder-trino-parquet: Retried waiting for GCLocker too often allocating 4194306 words

on CI.
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Dec 15, 2023
@cla-bot cla-bot bot added the cla-signed label Dec 15, 2023
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solves the symptom, why do we hit this though? The heap is already quite large.

@findepi
Copy link
Member Author

findepi commented Dec 15, 2023

@hashhar i don't think GCLocker-related problems are directly related to heap size. They are more related to eg native decompression (JNI causing GCLocker) and concurrency (some threads withing GC-locked regions and some threads trying to do normal Java allocation in young gen).

@findepi
Copy link
Member Author

findepi commented Dec 15, 2023

CI #20077

@wendigo wendigo merged commit 23be8c9 into trinodb:master Dec 15, 2023
88 of 90 checks passed
@github-actions github-actions bot added this to the 436 milestone Dec 15, 2023
@findepi findepi deleted the findepi/increase-gclocker-retries-for-maven-5afc31 branch December 15, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants