Fix table listing concurrency in FileHiveMetastore #20134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
findepi
force-pushed
the
findepi/fix-table-listing-concurrency-in-filehivemetastore-c0459c
branch
2 times, most recently
from
4906d33 to
95487d8
Compare
Before the change, `FileHiveMetastore` would rely on `fileSystem.listFiles` to find schemas or tables within a schema. `listFiles` is recursive and, on a local file system, fails when files/directories are being modified concurrently. This commit replaces recursive `listFiles` listing with non-recursive `listDirectories` leveraging the fact that listed entities are represented as directories.
findepi
force-pushed
the
findepi/fix-table-listing-concurrency-in-filehivemetastore-c0459c
branch
from
95487d8 to
5a10cbd
Compare
losipiuk
approved these changes
Dec 15, 2023
findepi
deleted the
findepi/fix-table-listing-concurrency-in-filehivemetastore-c0459c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change,
FileHiveMetastorewould rely onfileSystem.listFilesto find schemas or tables within a schema.listFilesis recursive and, on a local file system, fails when files/directories are being modified concurrently. This commit replaces recursivelistFileslisting with non-recursivelistDirectoriesleveraging the fact that listed entities are represented as directories.Fixes only partially #20130