Fix serialization failure when invoking json_table #20122
Conversation
The concrete type declared in the JsonTableFunctionHandle is not directly serializable. The deserializer binding is only declared for the Type class.
| @@ -6694,6 +6694,22 @@ SELECT a(10) | |||
| .hasMessage("line 3:8: Recursive language functions are not supported: a(integer):integer"); | |||
| } | |||
|
|
|||
| // ensure that JSON_TABLE runs properly in distributed mode (i.e., serialization of handles works correctly, etc) | |||
There was a problem hiding this comment.
i'd expect io.trino.sql.query.TestJsonTable to run in distributed mode.
There was a problem hiding this comment.
It didn't until recently, when we replaced LocalQueryRunner with StandaloneQueryRunner
There was a problem hiding this comment.
thanks for explaining.
and forgive my ignorance, what's the difference between StandaloneQueryRunner and DistributedQueryRunner?
I see StandaloneQueryRunner runs one node (which should be possible with DistributedQueryRunner, but may not be desirable), and also uses DirectTrinoClient to skip client protocol (also not sure if desirable). But i am sure i don't see the full picture.
There was a problem hiding this comment.
StandaloneQueryRunner is in trino-main and supports all the tests that live there.
The concrete type declared in the JsonTableFunctionHandle is not directly serializable. The deserializer binding is only declared for the Type class.
Release notes
(x) Release notes are required, with the following suggested text: