Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example for listagg with filter #20053

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add an example for listagg with filter #20053

merged 1 commit into from
Dec 19, 2023

Conversation

danielyahn
Copy link
Member

@danielyahn danielyahn commented Dec 7, 2023 •
edited
Loading

Description

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Dec 7, 2023
@github-actions github-actions bot added the docs label Dec 7, 2023
@danielyahn danielyahn requested review from mosabua and wendigo December 7, 2023 18:41
mosabua
mosabua requested changes Dec 15, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add this example we should also explain what it does..

docs/src/main/sphinx/functions/aggregate.md Outdated Show resolved Hide resolved
@danielyahn
Copy link
Member Author

@mosabua thank you for the feedback. pushed a commit to address these comments.

@danielyahn danielyahn requested a review from mosabua December 16, 2023 15:10
mosabua
mosabua reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address final requested changes and squash all commits into one commit. Then this is good to go

docs/src/main/sphinx/functions/aggregate.md Show resolved Hide resolved
@danielyahn danielyahn force-pushed the listagg-filter-example branch from 335be03 to 347540b Compare December 19, 2023 13:51
@danielyahn
Copy link
Member Author

@mosabua I think it should be good to go!

@danielyahn danielyahn requested a review from mosabua December 19, 2023 15:00
@mosabua mosabua force-pushed the listagg-filter-example branch from 347540b to c94df95 Compare December 19, 2023 16:39
mosabua
mosabua approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed wrapping, removed whitespace and updated commit message. Looks good now.

@mosabua mosabua merged commit a38ce40 into trinodb:master Dec 19, 2023
3 checks passed
@mosabua mosabua mentioned this pull request Dec 19, 2023
Merged
@github-actions github-actions bot added this to the 436 milestone Dec 19, 2023
@colebow colebow mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@wendigo wendigo Awaiting requested review from wendigo

Assignees
No one assigned
Labels
cla-signed docs
Milestone
436
Development

Successfully merging this pull request may close these issues.
2 participants
@danielyahn @mosabua