Test code cleanup around testJoinPushdown #19998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a test code like this
```
for (String operator : nonEqualities) {
assertJoinConditionallyPushedDown(
...
```
the raised exception would contain no information which case was the
failing one.
Apparently a syntactic transformation was applied: from "with parameters invoke test method" to "test method with a for loop over parameters". This didn't account for return statement that could potentially lead to cutting off portion of test coverage.
No need for separate method, if all testing is already covered by `testJoinPushdown`.
There is no need to recreate the test table for overy of the `for (JoinOperator` loop runs.
findepi
added
test
no-release-notes
findepi
commented
Dec 1, 2023
| if (joinOperator == FULL_JOIN && !hasBehavior(SUPPORTS_JOIN_PUSHDOWN_WITH_FULL_JOIN)) { | ||
| // Covered by verifySupportsJoinPushdownWithFullJoinDeclaration | ||
| return; | ||
| continue; |
losipiuk
approved these changes
Dec 8, 2023
Verification that "!SUPPORTS_JOIN_PUSHDOWN => join pushdown does not occur" is covered by `testJoinPushdown`, so `verifySupportsJoinPushdownDeclaration` was redundant.
findepi
force-pushed
the
findepi/create-test-table-once-in-testjoinpushdown-f28b9f
branch
from
bb17778 to
e94369a
Compare
findepi
deleted the
findepi/create-test-table-once-in-testjoinpushdown-f28b9f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for #19996