Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust BigQuery CI profile #19944

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Adjust BigQuery CI profile #19944

merged 1 commit into from
Dec 15, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Nov 29, 2023

Description

TestBigQueryAvroConnectorTest takes about 40 minutes.
TestBigQueryAvroTypeMapping takes about 10 minutes.

We shouldn't run those tests in a profile.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Nov 29, 2023
@github-actions github-actions bot added the bigquery BigQuery connector label Nov 29, 2023
@ebyhr ebyhr force-pushed the ebi/bigquery-ci-profile branch from 3a02995 to 3e8e3ac Compare November 29, 2023 01:40
@ebyhr
Copy link
Member Author

ebyhr commented Nov 29, 2023

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea LGTM. Naming might need improvement. Maybe just cloud-tests-1 and cloud-tests-2.

@@ -595,7 +589,7 @@

<!-- Separate profile for Arrow related tests since they require extra JVM args -->
<profile>
<id>cloud-tests-arrow-and-fte</id>
<id>cloud-tests-smoke</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name is misleading. It's smoke + "Important" (type-mapping, cleaner, metadata etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to cloud-tests-1 & cloud-tests-2.

@ebyhr ebyhr force-pushed the ebi/bigquery-ci-profile branch from 3e8e3ac to 8e5f08a Compare November 29, 2023 09:42
@ebyhr ebyhr requested a review from hashhar December 1, 2023 00:45
@ebyhr ebyhr requested a review from wendigo December 15, 2023 03:46
@wendigo wendigo merged commit a16cfdd into master Dec 15, 2023
98 checks passed
@wendigo wendigo deleted the ebi/bigquery-ci-profile branch December 15, 2023 21:12
@github-actions github-actions bot added this to the 436 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery BigQuery connector cla-signed
Development

Successfully merging this pull request may close these issues.

3 participants