-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore internal TableNotFoundException in DROP TABLE #19731
Conversation
95fbbe5
to
b954763
Compare
ci / pt (default, suite-8-non-generic, ) hit #16315 |
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergInternalRetry.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveInternalRetry.java
Outdated
Show resolved
Hide resolved
|
.../trino-hive/src/main/java/io/trino/plugin/hive/metastore/SemiTransactionalHiveMetastore.java
Outdated
Show resolved
Hide resolved
.../trino-hive/src/main/java/io/trino/plugin/hive/metastore/SemiTransactionalHiveMetastore.java
Outdated
Show resolved
Hide resolved
d28c2aa
to
0e828b4
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastore.java
Outdated
Show resolved
Hide resolved
337ef40
to
fc5e603
Compare
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/BridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/BridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
6dba470
to
85294b6
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/RetryDriver.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/RetryDriver.java
Outdated
Show resolved
Hide resolved
...test/java/io/trino/plugin/hive/metastore/thrift/TestingBehaviourModifiedMetastoreClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Show resolved
Hide resolved
85294b6
to
b21765a
Compare
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestingThriftHiveMetastoreBuilder.java
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftHiveMetastore.java
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/AbstractTestHiveMetastore.java
Outdated
Show resolved
Hide resolved
b21765a
to
3cabe12
Compare
CI hit: #16315 |
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/RetryDriver.java
Outdated
Show resolved
Hide resolved
3cabe12
to
60de40b
Compare
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/AbstractTestHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Show resolved
Hide resolved
...test/java/io/trino/plugin/hive/metastore/thrift/TestingTokenAwareMetastoreClientFactory.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/metastore/TestBridgingHiveMetastore.java
Outdated
Show resolved
Hide resolved
// If table is not found on consecutive attempts it was probably dropped on first attempt and timeout occurred. | ||
// Exception in such case can be safely ignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There're 2 places NoSuchObjectException can happen - getTable & dropTable. This comment is true for getTable, but what about dropTable?
Does dropTable method throw the exception only for table and doesn't throw the same exception for other reasons (e.g. failed to drop partitions due to concurrent operation)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about wrapping in an additional try/catch
the following line to make sure that the handling is done exclusively for the getTable
metastore call:
Table table = client.getTable(databaseName, tableName);
a90a658
to
fe16931
Compare
fe16931
to
a4bc7e8
Compare
Description
Ignore internal TableNotFoundException in DROP TABLE for Iceberg and Hive
Fixes #18848
Additional context and related issues
Release notes
( x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: