Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable failure detector in tests #19318

Conversation

findepi
Copy link
Member

@findepi findepi commented Oct 9, 2023

Actually: do not disable it in tests. Address a long-outstanding TODO comment.

Actually: do not disable it in tests. Address a long-outstanding TODO
comment.
@findepi findepi requested review from electrum and wendigo October 9, 2023 14:59
@cla-bot cla-bot bot added the cla-signed label Oct 9, 2023
@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Oct 9, 2023
@wendigo
Copy link
Contributor

wendigo commented Oct 9, 2023

Why was it disabled in the first place @findepi ?

@findepi
Copy link
Member Author

findepi commented Oct 13, 2023

I don't know. It was so since the commit which added the functionality.

@findepi findepi merged commit 008d44e into trinodb:master Oct 13, 2023
88 checks passed
@findepi findepi deleted the findepi/enable-failure-detector-in-tests-737328 branch October 13, 2023 14:29
@github-actions github-actions bot added this to the 430 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry test
Development

Successfully merging this pull request may close these issues.

2 participants