Accelerate Iceberg when reading partition columns only #19303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/iceberg-count-only
branch
from
7f1a960 to
7a10c4b
Compare
findepi
changed the title
|
cc @osscm |
findinpath
reviewed
Oct 6, 2023
| @@ -275,6 +273,7 @@ public void testReadWholePartition() | |||
| .addCopies(new FileOperation(METADATA_JSON, INPUT_FILE_NEW_STREAM), 1) | |||
There was a problem hiding this comment.
Please add tests when doing count(*) from the whole table.
Add a test involving a filter on a non partition column on a partitioned table.
Also important check the file system accesses for min(C)/max(C) .
Also add another test when there are delete files for the table.
findinpath
reviewed
Oct 6, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
findepi
changed the title
findepi
force-pushed
the
findepi/iceberg-count-only
branch
from
7a10c4b to
b587f51
Compare
Manifests contain trustworthy information about record count, so it can be used to answer the count(*) queries.
findepi
force-pushed
the
findepi/iceberg-count-only
branch
from
b587f51 to
b756564
Compare
losipiuk
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid data files I/O when
count(*)queries on Iceberg tables (with no group by, or grouping by partitioning columns)