Add Metadata.beginQuery #19291
Merged
Add Metadata.beginQuery #19291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require session to be already in a transaction Remove unused parameters from createPlan Remove most overloads in LocalQueryRunner
github-actions
bot
added
tests:hive
iceberg
electrum
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a beginQuery call that will be used for inline SQL language function registration. This call will only happen as part of transaction setup, so tests are updated to properly manage sessions.
This has been tested in #19290 using a modified MetadataManager that enforces registration. The enforcement is not part of this PR and is part of the sql language funcitons.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.