Don't set s3api create-bucket LocationConstraint configuration option for us-east-1 region #19248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesjmorgan
force-pushed
the
cm/optional-region-config-s3-ci
branch
from
364a510 to
d3cb0f4
Compare
charlesjmorgan
changed the title
charlesjmorgan
requested review from
electrum,
findepi,
nineinchnick,
losipiuk,
bitweld and
kokosing
|
Need to run ci with secrets, not sure if that can be done in this branch or if a clone of this branch should be made in the Trino repo |
charlesjmorgan
force-pushed
the
cm/optional-region-config-s3-ci
branch
from
d3cb0f4 to
ae9c700
Compare
|
Update to #19060 |
|
/test-with-secrets sha=ae9c7007801f1e350c59125b6cc977af31f7693f |
nineinchnick
approved these changes
Oct 4, 2023
|
|
||
| # LocationConstraint configuration property is not allowed for us-east-1 AWS region | ||
| if [ "${AWS_REGION}" == 'us-east-1' ]; then | ||
| optBucketConfiguration=("") |
There was a problem hiding this comment.
This should be an empty array, not an array with an empty string
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6401035079 |
Make the LocationConstraint create-bucket-configuration property optional depending on which aws region is used to run ci. LocationConstraint can't be set if the AWS_REGION used is us-east-1
charlesjmorgan
force-pushed
the
cm/optional-region-config-s3-ci
branch
from
ae9c700 to
d056382
Compare
|
Updated. PTAL @electrum |
nineinchnick
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
LocationConstraintcreate-bucket-configuration property optional depending on which aws region is used for ci.LocationConstraintcan't be set if the AWS region used isus-east-1. This doesn't affect Trino, but could affect forksAdditional context and related issues
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: