Convert tables in docs to markdown source #19237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
force-pushed
the
myst-tables
branch
4 times, most recently
from
d8bc4a8 to
ea17dab
Compare
mosabua
force-pushed
the
myst-tables
branch
3 times, most recently
from
d5fdd4e to
234361e
Compare
|
I rebased and updated again @electrum . Can you review? |
mosabua
changed the title
martint
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Purely changing format of source to use myst markdown directly rather than an eval-rst escape block.
I did a folder compare of the HTML output prior and after the change. User facing changes resulting from this refactor are rare, similar to other conversion tickets I did before. When there are changes I reviewed and made sure that the changes are an improvement.
I will follow up with another PR for all the connector docs and a few minor others separately.
Additional context and related issues
Follow up to various other conversion PRs.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.