Refactor create/insert base jdbc client #19224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
today we have lots of connectors which override entire beginInsert method for example even though they just want to change the generated query. And then over time the super impl improves to handle bugs or new features for example but the overridden code starts getting stale
hashhar
reviewed
Oct 3, 2023
Comment on lines
+662
to
+680
| for (ColumnMetadata column : columns) { | ||
| String columnName = identifierMapping.toRemoteColumnName(remoteIdentifiers, column.getName()); | ||
| verifyColumnName(connection.getMetaData(), columnName); | ||
| columnNames.add(columnName); | ||
| columnTypes.add(column.getType()); | ||
| columnList.add(getColumnDefinitionSql(session, column, columnName)); | ||
| } | ||
|
|
||
| Optional<String> pageSinkIdColumnName = Optional.empty(); | ||
| if (pageSinkIdColumn.isPresent()) { | ||
| String columnName = identifierMapping.toRemoteColumnName(remoteIdentifiers, pageSinkIdColumn.get().getName()); | ||
| pageSinkIdColumnName = Optional.of(columnName); | ||
| verifyColumnName(connection.getMetaData(), columnName); | ||
| columnList.add(getColumnDefinitionSql(session, pageSinkIdColumn.get(), columnName)); | ||
| } | ||
|
|
||
| RemoteTableName remoteTableName = new RemoteTableName(Optional.ofNullable(catalog), Optional.ofNullable(remoteSchema), remoteTargetTableName); | ||
| for (String sql : createTableSqls(remoteTableName, columnList.build(), tableMetadata)) { | ||
| execute(session, connection, sql); |
There was a problem hiding this comment.
let's keep just this section as the overridable part because this is the section which generates SQL via getColumnDefinitionSql and createTableSqls. Everything above this is something which MUST be common for all base-jdbc connectors anyway since it includes identifier mapping and naming rules.
Same for all the other methods.
vlad-lyutenko
force-pushed
the
vlad-lyutenko/rfct-insert-merge-jdbc
branch
from
87a5218 to
5a06e25
Compare
hashhar
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today we have lots of connectors which override entire beginInsert method for example even though they just want to change the generated query. And then over time the super impl improves to handle bugs or new features for example but the overridden code starts getting stale
Description
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: